Is this correct?

I don’t see any issues. You could probably leave “all” out of the sentence, but it can also be an intensifier, it just depends on context.

it’s a bit awkward but i dontttttt think it’s incorrect? i’d move the all so it reads “all for nothing” as that’s a common phrase.

“But all of this hasn’t been for nothing” would flow a bit better